Consolidate select menus dropdown in Nav block code #38179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
|
Size Change: +26 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
adamziel
reviewed
Jan 24, 2022
getdave
force-pushed
the
try/nav-block-consolidate-select-menus-dropdown
branch
from
b2ac0f4
to
a591571
Compare
getdave
force-pushed
the
try/nav-block-consolidate-select-menus-dropdown
branch
from
a591571
to
04dd9d9
Compare
adamziel
approved these changes
Feb 4, 2022
|
Looks good to me! Let's make the attributes non-configurable in a follow-up |
This was referenced Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #37190 we learnt that the Nav block has some inconsistencies and duplication in its codebase. This is now leading to bugs and regressions.
This PR tackles one of these areas which is the
Select menu...dropdown which appears inThis attempts to unify the presentational aspects. Further PRs might be warranted to encapsulate the permission checking and data fetching in order that we no longer duplicate that logic either.
How has this been tested?
Essentially this is a regression checking exercise. The block should behave exactly as it does on
trunk.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).