Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrast Checker: check link color #38100

Merged
merged 11 commits into from
Feb 7, 2022
Merged

Contrast Checker: check link color #38100

merged 11 commits into from
Feb 7, 2022

Commits on Feb 4, 2022

  1. Initial commit. Detecting the color of an A tag, if it exists and pas… 

    …sing it to the ConstrastChecker

Added base logic and tests.
Very messy. To be optimzized. Don't hate me.
    @ramonjd
    ramonjd committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    306888a View commit details
    Browse the repository at this point in the history

  2. A WIP commit. Reducing logic complexity into a hook. Will be squished.

    @ramonjd
    ramonjd committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    63d8402 View commit details
    Browse the repository at this point in the history

  3. WIP to be squashed. Using hook

    @ramonjd
    ramonjd committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    858e0ce View commit details
    Browse the repository at this point in the history

  4. Reducing logic with passing tests.

    @ramonjd
    ramonjd committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    c6e0b42 View commit details
    Browse the repository at this point in the history

  5. Extracting ContrastCheckerMessage component

    @ramonjd
    ramonjd committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    6658005 View commit details
    Browse the repository at this point in the history

  6. Extracting readable options

    @ramonjd
    ramonjd committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    4fd73ba View commit details
    Browse the repository at this point in the history

  7. Update DOM query to find an A tag even if its nested in, say, a stron… 

    …g or em tag.
    @ramonjd
    ramonjd committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    416337a View commit details
    Browse the repository at this point in the history

  8. This commit refactors the contrast checker to accept an array of text… 

    … colors.

This is so it can handle checking multiple text/foreground colors on a single background, e.g., text, link and so on.
Updating arguments and tests.
    @ramonjd
    ramonjd committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    00e5e31 View commit details
    Browse the repository at this point in the history

  9. Reverting change in ContrastChecker props model. These things should … 

    …be done iteratively as it touches too many parts, e.g. mobile.
    @ramonjd
    ramonjd committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    fafd100 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Update packages/block-editor/src/components/contrast-checker/index.js 

    Co-authored-by: Aaron Robertshaw <[email protected]>
    @ramonjd @aaronrobertshaw
    ramonjd and aaronrobertshaw committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    9d3e1fe View commit details
    Browse the repository at this point in the history

  2. Reorder dependencies 

    Update comment so that it reflects what's going on in the code.
    @ramonjd
    ramonjd committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    6976b04 View commit details
    Browse the repository at this point in the history