Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable alpha on Block Inspector Color ToolsPanel #37731

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Enable alpha on Block Inspector Color ToolsPanel #37731

merged 4 commits into from
Jan 20, 2022

Commits on Jan 20, 2022

  1. Initial commit: passing enableAlpha=true to the underlying ColorPicke… 

    …r component from the color tools panel.
    @ramonjd
    ramonjd committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    983a0f9 View commit details
    Browse the repository at this point in the history

  2. Show a warning in the color panel where either the text or background… 

    … color has transparency.

Adding tests.
Updating README.md to reflect the reality that colord does not check the contrast of colors with alpha transparency in our implementation.
    @ramonjd
    ramonjd committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    3d42ab1 View commit details
    Browse the repository at this point in the history

  3. enableContrastChecking if enableAlpha is true 

    only show the transparency warning where the text color alpha is < 1
ensure the readability/contrast warning takes precedence over the transparency warning
    @ramonjd
    ramonjd committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    5f667f4 View commit details
    Browse the repository at this point in the history

  4. Rename enable alpha prop to remove the experimental prefix

    @ramonjd
    ramonjd committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    2cb4303 View commit details
    Browse the repository at this point in the history