Navigation: Set the default for --navigation-layout-align to "flex-start" when using vertical orientation #37696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Bug
|
Size Change: +30 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
kjellr
changed the title
tellthemachines
approved these changes
Jan 5, 2022
kjellr
added
[Type] Regression
|
I think we should since it's a regression. I'll add the tag, but cc @noisysocks for a final call. Thanks! |
kjellr
added
the
Backport to WP 6.7 Beta/RC
|
Yep we can include this. |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 10, 2022
…art" when using vertical orientation (#37696) * Set the default to left justification. * Change the layout align default for the vertical orientation. * Restore value for layout-justify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37695
When vertical orientation is active,
--navigation-layout-alignshould be set toflex-start, so that items appear left-aligned as expected.Screenshots
Before:
After:
