Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query pagination: fixing placeholder display to work with vertical orientation too #37163

Closed
wants to merge 1 commit into from
Closed

Query pagination: fixing placeholder display to work with vertical orientation too #37163

wants to merge 1 commit into from

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Dec 6, 2021 •
edited
Loading

Description

Query pagination: hiding placeholder on flex-direction column

How has this been tested?

Wordpress 5.8.2
Gutenberg latest trunk version

Screenshots

flex.vertical2.mp4

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@matiasbenedetto matiasbenedetto mentioned this pull request Dec 6, 2021
Merged
7 tasks
@matiasbenedetto matiasbenedetto changed the title Query pagination: hiding placeholder on flex direction column Query pagination: fixing placeholder display to work with vertical orientation too Dec 6, 2021
@skorasaurus skorasaurus added the [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasbenedetto @skorasaurus