Fix mistake in _remove_theme_attribute_in_block_template_content #37137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #36898 I tried updating the
_remove_theme_attribute_in_block_template_content
to match core, but made a mistake in that I only copy/pasted theif
statement over from core (https://github.com/WordPress/gutenberg/pull/36898/files#r762692470).The part that I missed is that in WordPress core, the condition of the
if
statement was inverted. I should've updated the whole function.In this PR I'm fixing that.
Thanks to @noisysocks for spotting the issue.
How has this been tested?
I don't really know how to test this, but the function as defined in this PR should now match WordPress core:
https://github.com/WordPress/wordpress-develop/blob/7f1166c8918b4862fd1b8dd72ba6bf5b723b369e/src/wp-includes/block-template-utils.php#L466-L488
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.js
files for terms that need renaming or removal).