Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuItem: refactor to TypeScript and Emotion #37020

Closed
wants to merge 1 commit into from
Closed

MenuItem: refactor to TypeScript and Emotion #37020

wants to merge 1 commit into from

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Dec 1, 2021

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@ramonjd ramonjd added [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Dec 1, 2021
This was referenced Dec 1, 2021
Closed
Closed
@ramonjd
Copy link
Member Author

ramonjd commented Feb 22, 2022

Will come back to this later.

@ramonjd ramonjd closed this Feb 22, 2022
@ramonjd ramonjd deleted the refactor/menu-item-component-to-typescript branch February 22, 2022 22:23
@bangank36 bangank36 mentioned this pull request Jul 27, 2023
Closed
@bangank36
Copy link
Contributor

@ramonjd could I take over this issue to migrate the menu-item to typescript? It is part of the effort to provide missing stories for Gutenberg components, discussed here #36128 (comment)
Thanks 🙇

@ramonjd
Copy link
Member Author

ramonjd commented Jul 28, 2023

Could I take over this issue to migrate the menu-item to typescript?

You bet! It's all yours 😄

Thanks a lot!

@bangank36 bangank36 mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra will be requested when the pull request is marked ready for review ajitbohra is a code owner

Assignees
No one assigned
Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramonjd @bangank36