Add: Gradient palette editor #36820
Merged
Add: Gradient palette editor #36820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Status] In Progress
|
Size Change: +221 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/gradient-palette-editor
branch
2 times, most recently
from
ba82182
to
f090291
Compare
jorgefilipecosta
force-pushed
the
add/gradient-palette-editor
branch
from
f090291
to
5fc88e3
Compare
jorgefilipecosta
removed
the
[Status] In Progress
|
It looks like the gradients are not being visualized in the site editor (global styles and block settings sidebars). The reason is that the CSS Custom Properties are not in scope. There's already an issue to track this #30642 I still tested that selecting a gradient affects the styles of the block (block sidebar) and the global styles. Also tested that users can update the value of the gradient for default & theme styles and can create their own as well. So, the functionality added by this PR is working as expected. |
|
Got a potential fix for the issue with custom properties at #36851 I've also tested merging that branch into this one and it works as expected (gradients are visible, gradients can be edited, editing the gradients update the sidebar and the canvas, etc). |
oandregal
approved these changes
Nov 25, 2021
|
I'm tempted to merge this one before the fix for CSS custom properties. They are unrelated anyway. Going to wait a bit to see if the fix lands today. |
oandregal
added
the
[Feature] Site Editor
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
Co-authored-by: André <[email protected]>
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for the user to modify the gradient palettes.
How has this been tested?
I verified a user can change default, theme, and custom gradient palettes.