Framework: Check post type template as non-empty #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
youknowriad
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/WordPress/gutenberg/pull/3668/files#r153223493
This pull request seeks to resolve a notice which appears when editing a post in Gutenberg with high error reporting. Since the post type
$templatevariable is not set, a warning is logged:This pull request seeks to use the
emptyfunction to test whether the$templateproperty is both assigned and truthy.Testing instructions:
Repeat testing instructions from #3668
Verify that there are no warnings logged with high error reporting on the editor.