Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Group Control: add tooltip #36726

Merged
merged 5 commits into from
Nov 25, 2021
Merged

Toggle Group Control: add tooltip #36726

merged 5 commits into from
Nov 25, 2021

Commits on Nov 25, 2021

  1. Adding a ToolTip to the font-size-picker using the current label. 

    To avoid the TS linter freaking out, we add a default of `null` for the shortcut.
The 'position' prop, though helpful, is required for the same reason.
    @ramonjd
    ramonjd committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    16cdc1f View commit details
    Browse the repository at this point in the history

  2. Allow a new prop tooltipText to be passed down to `ToggleGroupContr… 

    …olOption` to determine whether to show tooltip

Update stories.
    @ramonjd
    ramonjd committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    eeeecb3 View commit details
    Browse the repository at this point in the history

  3. Changed the prop from text to a boolean in order to flag displaying t… 

    …he tooltip.

Adding tests.
Updated README.md for ToggleGroupControl
Updated CHANGELOG.md

Updated label condition
Updated story
Co-authored-by: Aaron Robertshaw <[email protected]>

Removed unneeded export and __ import
    @ramonjd
    ramonjd committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    607a92d View commit details
    Browse the repository at this point in the history

  4. Updated CHANGELOG.md 

    Destructuring Tooltip props to hide them from the TS linter
Updating tests to account for the Tooltip timers.
    @ramonjd
    ramonjd committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    4ef7fc5 View commit details
    Browse the repository at this point in the history

  5. testing tooltip active state using the focus event, which doesn't emp… 

    …loy useDebounce for now.
    @ramonjd
    ramonjd committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    7c80be0 View commit details
    Browse the repository at this point in the history