Gallery block: Fix issue with columns and link destination not copying across when gallery updated to v2 format #36388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allery updated to v2 format
glendaviesnz
added
the
[Block] Gallery
|
Size Change: +7 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
This is testing nicely @glendaviesnz, thanks for putting it together! I'm not sure if there'll be a point release for 11.9 going out, but I'll merge this in, so that if a point release does wind up being pushed, this change will be included. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a v1 Gallery block is migrated using the
Updatebutton thecolumnsandlinkDestinationattributes are not being copied across to the new gallerHow has this been tested?
wp option set use_balanceTags 1)use_balanceTagsswitched back offUpdatebutton in the block toolbar to update the Gallery to v2 formatScreenshots
Before:
After:
