Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Supports: Allow skipping serialization of individual features #36293

Merged
merged 16 commits into from
Mar 29, 2022
Merged

Block Supports: Allow skipping serialization of individual features #36293

merged 16 commits into from
Mar 29, 2022

Commits on Mar 28, 2022

  1. Update styles hook to allow skipping individual feature serialization

    @aaronrobertshaw
    aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    0a91b2d View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @aaronrobertshaw
    aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    21d79ac View commit details
    Browse the repository at this point in the history

  3. Update JS serialization checks

    @aaronrobertshaw
    aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    5f74aa9 View commit details
    Browse the repository at this point in the history

  4. Update PHP block support serialization checks

    @aaronrobertshaw
    aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    2f7d0b5 View commit details
    Browse the repository at this point in the history

  5. Add skip serialization checks for link colors and block gap

    @aaronrobertshaw
    aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    36db79b View commit details
    Browse the repository at this point in the history

  6. Skip enforcing inline color styles and fix gradients

    @aaronrobertshaw
    aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    3ebb552 View commit details
    Browse the repository at this point in the history

  7. The call to gutenberg_skip_color_serialization() from elements.php … 

    …sometimes does not pass a valid $block_type, which must be an object. It is `NULL`. Perhaps due to a race condition. This commit checks if $block_type is an object before trying to use it.
    @ramonjd @aaronrobertshaw
    ramonjd authored and aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    4f5844f View commit details
    Browse the repository at this point in the history

  8. This commit ensures that defining `"__experimentalSkipSerialization":… 

    … [ "blockGap" ]` has an effect on the frontend and in the editor.

The blockGap value, where defined by the user, will not be applied.

Added a comment clarifying the use of skip serialization in relation to blockGap
    @ramonjd @aaronrobertshaw
    ramonjd authored and aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    2d8364d View commit details
    Browse the repository at this point in the history

  9. Move shouldSkipSerialization to utils module to avoid side-effects of… 

    … importing from style.js
    @andrewserong @aaronrobertshaw
    andrewserong authored and aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    842d051 View commit details
    Browse the repository at this point in the history

  10. Format whitespace of an import

    @andrewserong @aaronrobertshaw
    andrewserong authored and aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    4737807 View commit details
    Browse the repository at this point in the history

  11. Updated tests to test the renamedFeatures object.

    @ramonjd @aaronrobertshaw
    ramonjd authored and aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    50b1e6d View commit details
    Browse the repository at this point in the history

  12. Adding block supports tests 

    Adding skip serialization tests
    @ramonjd @aaronrobertshaw
    ramonjd authored and aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    cf77a62 View commit details
    Browse the repository at this point in the history

  13. Extract gutenberg_should_skip_block_supports_serialization to a uti… 

    …ls file.
    @ramonjd @aaronrobertshaw
    ramonjd authored and aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    0b509c6 View commit details
    Browse the repository at this point in the history

  14. remove bad copy/pasta reference to typography

    @ramonjd @aaronrobertshaw
    ramonjd authored and aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    98f6d43 View commit details
    Browse the repository at this point in the history

  15. Renamed skipSerialization method to reflect the closure context (Elem… 

    …ents API)

Added a dev comment to warn about future changes (if any) to the Elements API
    @ramonjd @aaronrobertshaw
    ramonjd authored and aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    2d23711 View commit details
    Browse the repository at this point in the history

  16. Fix whitespace errors in spacing support php tests

    @aaronrobertshaw
    aaronrobertshaw committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    aa0e91d View commit details
    Browse the repository at this point in the history