Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to manage wp_navigation posts from wp-admin #36126

Merged
merged 16 commits into from
Nov 5, 2021
Merged

Provide a way to manage wp_navigation posts from wp-admin #36126

merged 16 commits into from
Nov 5, 2021

Commits on Nov 3, 2021

  1. Disable block editor for wp_navigation CPT (it doesn't work yet) so i… 

    …t can be managed using the standard UI.
    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    c9e948e View commit details
    Browse the repository at this point in the history

  2. Disable ability to edit wp_navigation type posts because the post edi… 

    …tor doesn't correctly work with wp_navigation posts.
    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    aa0ff7e View commit details
    Browse the repository at this point in the history

  3. Don't call get_posts when it's not needed.

    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    f91c5fb View commit details
    Browse the repository at this point in the history

  4. Add unit tests for navigation.php.

    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    0a243b3 View commit details
    Browse the repository at this point in the history

  5. Fix code style.

    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    066bf4a View commit details
    Browse the repository at this point in the history

  6. Fix code style.

    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    0f8688e View commit details
    Browse the repository at this point in the history

  7. Fix code style.

    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    566c159 View commit details
    Browse the repository at this point in the history

  8. Use get_post_type because it validates empty $post values.

    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    cf83ec2 View commit details
    Browse the repository at this point in the history

  9. 1. Disable content editor for wp_navigation type posts. 

    Content editor cannot correctly edit them.
2. Add unit tests.
    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    ec24e72 View commit details
    Browse the repository at this point in the history

  10. Fix menu entry. 

    Rename it to "Navigation Menus".
    @anton-vlasenko
    anton-vlasenko committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    39e9570 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Enable editor support back. 

    We need to enable it back because we disable it to hide the content editor windows. This is required to avoid the incorrect state of wp_navigation CPT.
    @anton-vlasenko
    anton-vlasenko committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    3ecd7b6 View commit details
    Browse the repository at this point in the history

  2. Fix the unit test.

    @anton-vlasenko
    anton-vlasenko committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    14a08e8 View commit details
    Browse the repository at this point in the history

  3. Refactor the gutenberg_fix_navigation_items_admin_menu_entry function. 

    The new name better describes the purpose of the function.
    @anton-vlasenko
    anton-vlasenko committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    baccf37 View commit details
    Browse the repository at this point in the history

  4. Rename variables to improve clarify of the code.

    @anton-vlasenko
    anton-vlasenko committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    a6abfca View commit details
    Browse the repository at this point in the history

  5. Fix description of the class.

    @anton-vlasenko
    anton-vlasenko committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    38dbd8e View commit details
    Browse the repository at this point in the history

  6. Fix PHPDOC block. Now description better explains the purpose of this… 

    … callback function.
    @anton-vlasenko
    anton-vlasenko committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    3bee078 View commit details
    Browse the repository at this point in the history