Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Try out variables substitutions in block templates #36059

Closed
wants to merge 5 commits into from

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Oct 28, 2021

Description

A test to see how variable substitution may work for templates.

Testing ideas for #31815

How has this been tested?

Use a block theme.

Add a dummy image in one of your templates where you want your image to go.

Replace the image URL from dummy image with: {{ template_directory_uri }}/assets/image.jpg where assets/image.jpg is the local file in your theme. This needs to be done in a text editor, not from within WordPress.

Reload theme page and it should work.

Types of changes

Just a test.

@mkaz mkaz added the [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. label Oct 28, 2021
@mkaz mkaz marked this pull request as draft October 28, 2021 18:55
@mkaz
Copy link
Member Author

mkaz commented Dec 1, 2021

I'm closing as I don't think this is the approach we want. It can always be reopened later if it is.

@mkaz mkaz closed this Dec 1, 2021
@mkaz mkaz deleted the try/template-variabls branch December 1, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant