WIP: Use inner blocks for lists #35870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -848 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
There should be some prior work from @ellatrix to bring nested blocks support for the List block. I know that @oandregal worked on the same type of changes to the Query block in #25892 but he put it on hold because of his involvement in the Global Styles project. |
|
Quote should be much, much easier than lists. A list item also needs to support nesting a whole other list after the text: <ol>
<li>item 1
<ol>...</ol>
</li>
</ol>So there could be a list block and a list item block which can be an inner block of the list block. But then inside the list item block it needs to be possible to append another list block. The contents of this sublist are tied to the parent list item's text. Similarly when moving a list item up or down, the sublist tied to that list item should move up or down with it. |
It's on my TODO list to jump over to #25892 and see if there's any way I can help with that one.
if I understand you properly this is already supported even in this PR (although it's not like the current state of this exploratory PR is something that we could talk about merging). Still, the |
|
This would make #31733 significantly easier, since it would be transforming one block tree to another instead of parsing HTML. |
dmsnell
force-pushed
the
dmsnell/nested-lists
branch
from
192ebd6
to
5a731f9
Compare
|
#39487 added similar functionality. The alternative PR keeps the old and new implementation as it is necessary for the transition period. Let's close this one as a duplicate. |
gziolo
added
the
[Status] Duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lists in HTML are more like containers than sequences of paragraphs. How can we make list blocks generic containers?