Navigation: Fix padding for social links on mobile #35824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
[Block] Navigation
7 tasks
jasmussen
reviewed
Oct 21, 2021
| @@ -465,7 +465,7 @@ | |||
| } | |||
|
|
|||
| // A default padding is added to submenu items. It's not appropriate inside the modal. | |||
| a { | |||
| a:not(.wp-block-social-link-anchor) { | |||
There was a problem hiding this comment.
Instead of a, could you target .wp-block-navigation-item__content instead? That will both make the selector simpler, and fix the problem for any other nested blocks that might add links, like site logo or title.
|
@jasmussen you mentioned that we could directly target |
|
Size Change: -3 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
We were both typing at the same time 😅 Yes, I think the class is better, because the zeroing out of padding is meant only for menu items, but menu items also includes click-only dropdown items, which are |
|
Tests are green 👌 |
fullofcaffeine
added a commit
that referenced
this pull request
Oct 21, 2021
* trunk: (494 commits) remove consecutive rc warning (#35855) Update Changelog for 11.8.0-rc.2 Bump plugin version to 11.8.0-rc.2 [RNMobile] Disable React Native E2E Tests (iOS) (#35844) Add section about using the schema during development (#35835) Add a method to disable auto-accepting dialogs (#35828) Wrap NavigationContainer with SafeAreaView. (#35570) Update Appium to 1.22.0 (#35829) Post Comment: Handle the case where a comment does not exist (#35810) Clear selected block when clicking on the gray background (#35816) Post excerpt: Don't print the wrapper when there is no excerpt (#35749) [Block] Navigation: Fix padding for social links on mobile (#35824) Fix issue with responsive navigation causing wrapping. (#35820) [Block Editor]: Fix displaying only `none` alignment option (#35822) Add API to access global settings, styles, and stylesheet (#34843) Mobile Release v1.64.1 (#35804) Add resizer to template part focus mode (#35728) Update Changelog for 11.7.1 Gallery block: Only show the gallery upload error message if mixed multiple files uploaded (#35790) Update Changelog for 11.8.0-rc.1 ...
andrewserong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resetting padding to 0 for links on the responsive navigation menu was affecting social links as well. This PR avoids applying that rule to social links.
How has this been tested?
Using emptytheme with the following markup:
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).