Components: refactor Navigator* folder structure, rename Navigator to NavigatorProvider
#35160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
ciampo
requested review from
youknowriad,
diegohaz,
jorgefilipecosta and
ntsekouras
|
Size Change: +4 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Sep 28, 2021
packages/components/src/index.js
Outdated
| @@ -97,7 +97,7 @@ export { default as __experimentalNavigationGroup } from './navigation/group'; | |||
| export { default as __experimentalNavigationItem } from './navigation/item'; | |||
| export { default as __experimentalNavigationMenu } from './navigation/menu'; | |||
| export { | |||
| Navigator as __experimentalNavigator, | |||
| NavigatorRoot as __experimentalNavigatorRoot, | |||
There was a problem hiding this comment.
To be honest I don't like the name NavigatorRoot. I feel it can be confused with the "Root Screen". In other places in the UI Components we use Provider so maybe NavigatorProvider would be better for me. That said, don't take my word for it, I know I'm not great at naming things :P
There was a problem hiding this comment.
Naming things is hard, and doing so in a project like Gutenberg is even harder! NavigatorProvider sounds good to me, I'll go ahead and make changes
ciampo
changed the title
Navigator's folder structure, rename to NavigatorRootNavigator* folder structure, rename Navigator to NavigatorProvider
ciampo
force-pushed
the
feat/components-navigator-folder-structure
branch
from
aa7f003
to
c2f0a3a
Compare
@youknowriad , this PR is ready for another round of review |
|
Edit: actually nevermind, my bad. Looks like the 2 parallel PRs didn't cause any conflicts. Sorry for the ping! |
This was referenced Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a series of smaller PRs that aim at refining the family of
Navigatorcomponents and is part of a larger effort tracked in #34907.This PR slightly refactors the folder structure of the
Navigator*components family, following the contributing guidelines:Navigatorhas been renamed toNavigatorProvider(also to avoid confusion with theuseNavigatorhook, which could be otherwise mistaken for the hook of theNavigatorcomponent)NavigatorProviderandNavigatorScreenhave been moved to subfolders, respectivelynavigator-providerandnavigator-screenNavigatorScreenNavigatorto now referenceNavigatorProviderFuture follow-up PRs will introduce unit tests and refactor the family of components to TypeScript.
How has this been tested?
There are no runtime changes.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).