Eslint plugin: Use @typescript-eslint/no-duplicate-imports in TS projects #34055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update eslint plugin to use
@typescript-eslint/no-duplicate-imports
on TypeScript projects. This rule extends the baseeslint/no-duplicate-imports
rule and adds support for type-only import and export.See https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-duplicate-imports.md
This allows importing types and exports from the same package without trowing an error. All files that import types today in Gutenberg adds a
// eslint-disable-next-line no-duplicate-imports
to avoid it. This PR fixes so these are no longer needed.How has this been tested?
Locally by running
npm run lint-js
Types of changes
Code quality
Checklist:
*.native.js
files for terms that need renaming or removal).