[Mobile] - Color settings - Update label and show the selected color value #33973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd display the selected hex color.
geriux
added
the
Mobile App - i.e. Android or iOS
2 tasks
|
Hey @iamthomasbishop 👋 I made the changes to update the label and to also display the selected color hex value. Do you want a build to test it or is it ok with just the gifs from the PR description? Thanks! |
|
Size Change: 0 B Total Size: 1.03 MB ℹ️ View Unchanged
|
antonis
reviewed
Aug 10, 2021
There was a problem hiding this comment.
Great work @geriux 👍
The code changes LGTM. While testing the app on Android I noticed that the new label is not shown when the gradient selector is shown (e.g. on buttons or cover block) and wanted to verify if this is intentional before proceeding with testing iOS.
screenshot
This is out of scope but I wonder if this user request to be able to edit the hex value is a quick win in a follow up PR. Wdyt @iamthomasbishop?
Yeah if background gradients are supported for the block, you'll see the Color/Gradient selector instead of the label. I've should've mentioned that the change it's for text color settings and not backgrounds. 😅 |
antonis
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
if background gradients are supported for the block, you'll see the Color/Gradient selector instead of the label.
Considering this I've tested the implementation on Android (Google Pixel 5, Android 12) and iOS (iPhone SE 2020, iOS 14.4.1). Everything works as expected 🎉
Thank you for this improvement @geriux 🙇
Closed
2 tasks
|
Hey @iamthomasbishop this is ready to be merged but I wanted to double-check with you if before doing it. Do you want a build to test this or is it ok if you just review the gifs from the description above? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#3766
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#3817Description
This PR updates the label of the color settings palette from
Select a colortoSelect a color above.It also adds the functionality to display the color selected and the ability to copy it.
How has this been tested?
Paragraphblock.Screenshots
Types of changes
New change
Checklist:
*.native.jsfiles for terms that need renaming or removal).