components: Convert Select to TypeScript #33784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +15 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
7 tasks
ciampo
reviewed
Aug 2, 2021
5 tasks
ciampo
reviewed
Aug 2, 2021
| @@ -1,8 +1,10 @@ | |||
| /** | |||
| * External dependencies | |||
| */ | |||
| import { isEmpty, noop } from 'lodash'; | |||
| import { isEmpty, noop, omit } from 'lodash'; | |||
There was a problem hiding this comment.
Just realised this — can the omit import be removed now? I don't see any further usages.
We may want to apply this change directly in #33696
sarayourfriend
added a commit
that referenced
this pull request
Aug 6, 2021
* components: InputControl to TypeScript * Add back event to onChange * Fix on validate and remove todo * Remove cast and allow undefined values * Add explanatory comment for omitting prefix * Use currentTarget * components: Convert Select to TypeScript (#33784) * Convert Select to TypeScript * Stop spreading props into InputBase and add all HTML attributes for select * Remove need for `omit` * Remove unused import * Consistently use currentTarget * Require isFocused props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts the SelectControl to TypeScript. Depends on the InputControl conversion.
I did this as part of #33714 so just splitting it into a separate PR.
How has this been tested?
Types should pass. There are no runtime changes 🙂
Types of changes
Code quality
Checklist:
*.native.jsfiles for terms that need renaming or removal).