Add Convert to Regular Blocks button to ellipsis Dropdown

[thisissandip]

Fixes #32217

Description

Added convert to regular blocks button to ellipsis dropdown for reusable blocks

How has this been tested?

1. Select a Reusable Block
2. Select more options button (three vertical dots) in the Block Toolbar
3. Select Convert to Regular Blocks
4. This should convert the reusable block to independent regular blocks

Screenshots

convert_regular_blocks.mov

Types of changes

Bug fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

[ntsekouras]

Thanks for working on this @thisissandip !

While the code here looks good, this changed was introduced here: https://github.com/WordPress/gutenberg/pull/28318/files#diff-3e104de22b2ea1fac4d9f2fd42f07a1c8ff39bcb9d0bfa43b056538e74e1c558R124

and I'm wondering if there had been related discussion about this and this change happened.

--cc @mtias @jasmussen

[ntsekouras]

Also related: #30993

[paaljoachim]

I am linking in this Trac comment: https://core.trac.wordpress.org/ticket/52779#comment:25

[jasmussen]

Thanks for the PR! I don't have a strong opinion here: the menu item is redundant duplicate UI to the button in the toolbar (which by the way is an icon button as the reusable block name can and often will grow very long). Redundant UI can be okay.

I would follow the sentence case menu item standards, though, so it should be "Convert to regular blocks" not "Convert to Regular Blocks".

[ntsekouras]

LGTM 👍 - thanks!

Let's land with a green CI.

[paaljoachim]

@ntsekouras or @thisissandip

Be sure to also get this included:

I would follow the sentence case menu item standards, though, so it should be "Convert to regular blocks" not "Convert to Regular Blocks".

Thanks for approving and merging this PR, Nik!

[paaljoachim]

@peterwilsoncc Peter. We have a possible merged PR that can be backported to WP 5.7.3.

[ntsekouras]

Be sure to also get this included:
I would follow the sentence case menu item standards, though, so it should be "Convert to regular blocks" not "Convert to Regular Blocks".

It's included yes.

[thisissandip]

Thank you for reviewing and merging this PR! @ntsekouras @paaljoachim @jasmussen

[paaljoachim]

@youknowriad Should we backport this PR into WP 5.8?
It gives the additional option in the ellipsis drop down to convert a Reusable block into a regular block. It was added because the icon in the toolbar is very easy to overlook. (We have yet to change the icon to something that better represents the convert process.) Adding the option into the ellipsis makes it easier for people to discover a place where convert can happen.

[desrosj]

As mentioned on #34393, I've decided to not include this in 5.8.1 as this is more of a bug fix by way of enhancement. I think adding UI elements and controls should only be done in minor releases when absolutely necessary.