-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featured Image Block: fix img alignment styles #31940
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
added
the
[Block] Post Featured Image
Affects the Post Featured Image Block
label
May 18, 2021
kjellr
approved these changes
May 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches the behavior from the image block, so it makes sense to me. Thank you!
carolinan
approved these changes
May 18, 2021
Size Change: +80 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
jffng
force-pushed
the
fix/featured-image-block-alignment
branch
from
May 19, 2021 12:42
853895c
to
395348a
Compare
* Add undo redo and debounce * Style the undo redo button * Bail out updates if the next widgets are the same * Add debounce * Add missing keyboard shortcuts * Fix styling
Co-authored-by: Daniel Richards <[email protected]>
Co-authored-by: Carolina Nymark <[email protected]>
…le (#31524) Co-authored-by: André <[email protected]> (+3 squashed commits)
Co-authored-by: Riad Benguella <[email protected]>
Co-authored-by: ntsekouras <[email protected]>
…o `displayLayout` (#31833)
jffng
force-pushed
the
fix/featured-image-block-alignment
branch
from
May 19, 2021 19:00
395348a
to
e867673
Compare
jffng
requested review from
chrisvanpatten,
ellatrix,
mkaz,
nerrad,
oandregal,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
May 19, 2021 19:00
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Post Featured Image block relies on figure > img to display the image. The block supports wide and full alignment.
This PR adds some CSS to ensure the image spans the entire width of the container when alignment is set on the block. This is similar to what's done for the image block: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/image/style.scss#L16-L19
How has this been tested?
Using emptytheme, add a featured image block, set its alignment to full or wide.
Screenshots
(Apologies that my featured image is a screenshot of the browser inspector 😅 )
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).