Navigation Editor: Move selected menu ID to the store #31320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes useSelectedMenuData hook * Removes MenuIdContext
Mamaduka
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
Mamaduka
added
[Feature] Navigation Screen
[Type] Enhancement
|
Size Change: -994 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
getdave
approved these changes
May 4, 2021
There was a problem hiding this comment.
I tested this and it did indeed select the last menu I had selected displayed when reloading. I also saw the value in localStorage.
This also works if you delete all menus - there are no errors.
I don't know much about the persistence plugin but it seemed to work well.
Update: looks like you have a failing e2e test.
| @@ -73,7 +75,7 @@ export default function useNavigationEditor() { | |||
| force: true, | |||
| } ); | |||
| if ( didDeleteMenu ) { | |||
| setSelectedMenuId( null ); | |||
| setSelectedMenuId( 0 ); | |||
There was a problem hiding this comment.
Just checking...is it safe to set this to 0? What if there are no menus left?
There was a problem hiding this comment.
If there are no menus left, the screen will display create menu placeholder. I'm using 0 here so we can have a single type for selectedMenuId. But having null as in no menu was selected also makes sense to me.
7 tasks
This was referenced May 28, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to move currently selected menu ID to the store. Value is synced to localStorage as suggested here #31132 (comment).
PR introduces new actions/selector for working with selected menu ID.
Other changes
useSelectedMenuIdhook for convenience.useSelectedMenuDatahook andMenuIdContext.Fixes #22623.
How has this been tested?
Testing the store changes:
npm run test-unit -- packages/edit-navigation/src/store/testTypes of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).