Split theme.css styles loading
#31239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
2 tasks
aristath
added
[Feature] Full Site Editing
[Feature] Themes
aristath
requested review from
ajitbohra,
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
ntsekouras
reviewed
Apr 28, 2021
ntsekouras
reviewed
Apr 28, 2021
aristath
force-pushed
the
try/split-theme-styles
branch
2 times, most recently
from
66f9c39
to
3690dea
Compare
aristath
force-pushed
the
try/split-theme-styles
branch
from
3690dea
to
9cb4178
Compare
ntsekouras
approved these changes
Jun 11, 2021
17 tasks
aristath
added a commit
to aristath/wordpress-develop
that referenced
this pull request
Nov 4, 2021
noisysocks
pushed a commit
to noisysocks/wordpress-develop
that referenced
this pull request
Nov 5, 2021
noisysocks
pushed a commit
to noisysocks/wordpress-develop
that referenced
this pull request
Nov 8, 2021
noisysocks
pushed a commit
to noisysocks/wordpress-develop
that referenced
this pull request
Nov 8, 2021
noisysocks
pushed a commit
to noisysocks/wordpress-develop
that referenced
this pull request
Nov 8, 2021
noisysocks
pushed a commit
to noisysocks/wordpress-develop
that referenced
this pull request
Nov 8, 2021
noisysocks
pushed a commit
to noisysocks/wordpress-develop
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #25220 and #28358, this PR splits styles that are currently included in
theme.css, and adds them to block-styles usingwp_add_inline_style.How has this been tested?
Tested in an FSE theme by adding
add_theme_support( 'wp-block-styles' );and then making sure thattheme.cssdoesn't get loaded, and instead individual styles get added to the split block styles.Note: #31268 was a result of this effort and makes sure that theme styles get added after core styles.
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).