Fix is-link style to take colors from wp-admin theme. #30823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
General Interface
|
Size Change: -104 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Apr 14, 2021
| box-shadow: | ||
| 0 0 0 $border-width #5b9dd9, | ||
| 0 0 var(--wp-admin-border-width-focus) $border-width rgba(30, 140, 190, 0.8); | ||
| border-radius: $radius-block-ui; | ||
| } |
There was a problem hiding this comment.
Why did you remove all these styles? I worry about the impact
There was a problem hiding this comment.
Because those styles are from the older wp-admin styles. I don't mean to dismiss the feedback, but it's similar to when the button styles changed from bevelled to flat.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
is-linkbuttons did not get their colors from your wp-admin color theme. This PR fixes that. Before:After:
Previously: #6562
Checklist:
*.native.jsfiles for terms that need renaming or removal).