Editor: Handle case where unavailable siteData is causing WSOD #30812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WunderBart
added
the
[Type] Bug
|
Size Change: +1.42 kB (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
gwwar
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Thanks for looking into this one @WunderBart, changes here test well for me.
I verified that we see an error of TypeError: Cannot read property 'isBeingScheduled' of undefined when filterURLForDisplay is called without a string value. The guard here prevents this.
| <span className="components-site-name">{ siteTitle }</span> | ||
| <span className="components-site-home">{ siteHome }</span> | ||
| </div> | ||
| { ( siteTitle || siteHome ) && ( |
There was a problem hiding this comment.
How about if we move the render check above to <div className="components-site-card">
Currently in we'll see just an icon otherwise:
There was a problem hiding this comment.
Also the individual checks that follow after should not be there
There was a problem hiding this comment.
And honestly, in terms of UI, these values should always be there or have a fallback to "(Untitled)" at most.
There was a problem hiding this comment.
Thanks for your feedback, folks! 🙇
And honestly, in terms of UI, these values should always be there or have a fallback to "(Untitled)" at most.
Considering we want the block to be always visible, I'd say this would be the minimal version of it, where none of the values are available:
I haven't put anything in place of the siteHome (URL) - I think it's OK to just leave it empty. What do you think?
Does anyone know why |
The third arg is the Still don't know the answer to the question though. I guess there's no need for a key? |
Shouldn't usage here be
Getters are generated here: gutenberg/packages/core-data/src/entities.js Lines 21 to 25 in 06fd22e gutenberg/packages/core-data/src/entities.js Lines 203 to 228 in 06fd22e |
|
Cherry-picked to |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug introduced in #30231, where the WSOD is thrown in the pre-publish phase if the
siteDataobject is empty.How has this been tested?
siteDataobject to be empty,Publishbutton - WSOD should not be thrown,siteTitleandsiteHomeelements in the pre-publish panel and make sure they're not rendered empty.Screenshot
Errors thrown when
siteDataobject is unavailable:Types of changes
Bug fix (non-breaking change which fixes an issue)