Refactor MetaBoxesArea to to functional components using hooks. #30542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.21 kB (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
torounit
changed the title
torounit
added
[Type] Code Quality
Mamaduka
reviewed
Apr 7, 2021
packages/edit-post/src/components/meta-boxes/meta-boxes-area/index.js
Outdated
Show resolved
Hide resolved
Mamaduka
reviewed
Apr 7, 2021
packages/edit-post/src/components/meta-boxes/meta-boxes-area/index.js
Outdated
Show resolved
Hide resolved
|
Hi, @torounit Thanks for working on this.
|
|
@torounit, sorry for the late follow-up on this PR. Can you rebase the current trunk? I'll do another round of tests, and we're good to land this 👍 |
|
I made a few changes. And I've included trunk. Can I have you test it? |
|
Thanks, @torounit I will test this first thing in the morning tomorrow 👍 |
|
Sidenote: I think it's preferred method to use But this isn't a blocker. |
|
@torounit, I think we're good to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: #22890 his PR refactors the
MetaBoxesAreacomponent into a function component using React hooks.How has this been tested?
Show block editor and check custom field metabox and others.
Checklist:
*.native.jsfiles for terms that need renaming or removal).