Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix Gboard enter detection in EnterPressedWatcher #30368

Closed
wants to merge 6 commits into from
Closed

[Android] Fix Gboard enter detection in EnterPressedWatcher #30368

wants to merge 6 commits into from

Commits on Mar 30, 2021

  1. Add logic to address Gboard's unusual invocation of TextWatcher methods 

    Note: This is probably not enough, since this only addresses when the
caret is at the end of the word, but Gboard may exhibit the unusual
behavior also when the caret is in the middle or start of the word.
    @mkevins
    mkevins committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    5581743 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Revert "Add logic to address Gboard's unusual invocation of TextWatch… 

    …er methods"

This reverts commit 5581743.
    @mkevins
    mkevins committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5da76c7 View commit details
    Browse the repository at this point in the history

  2. Search for newline in newTextCopy

    @mkevins
    mkevins committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    93bbd1f View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Merge branch 'trunk' into rnmobile/try/fix-gboard-enter-detection

    @mkevins
    mkevins committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    2ea1654 View commit details
    Browse the repository at this point in the history

  2. Revert "Search for newline in newTextCopy" 

    This reverts commit 93bbd1f.
    @mkevins
    mkevins committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    fca904d View commit details
    Browse the repository at this point in the history

  3. Revert "Revert "Add logic to address Gboard's unusual invocation of T… 

    …extWatcher methods""

This reverts commit 5da76c7.
    @mkevins
    mkevins committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    7363bb5 View commit details
    Browse the repository at this point in the history