Navigation Link: Limit Nesting Depth to 5 #30199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.3 kB (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
This works excellently well. Very very simple, the button simply disappears:
It's a smallstep and I still need to think about how it works when the navigation gets so wide it adds a horizontal scrollbar, but that's a separate thing that will still need this change to happen. Question: which theme are you testing in here? I'm seeing a weird extra amount of spacing between items. |
7 tasks
added 2 commits
April 6, 2021 11:26
georgeh
force-pushed
the
add/nav-link-limit-nesting
branch
from
a918f12
to
ebbb62c
Compare
Can I get a 👍🏻 to merge? |
|
Is intended behavior here to allow existing nested menus to be > 5, and only disable adding on edit? |
|
Thanks for looking at this one @georgeh! I think the approach is pretty reasonable and this tests well. If an existing menu has a depth of > 5, content is preserved. E2E tests and static lint checks are ❌ . If E2Es still fail after a rebase with trunk, let 🔍 a bit. If the test is flakey we can try and get a codeowner to 🔍 more deeply. |
|
@gwwar the intended goal is to stop people from adding beyond 5, but if they already have a depth beyond 5 I don't think we should truncate that. I also messed up something with a rebase so I'm retracing my steps, and that should fix the (correctly) failing checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21691
Description
Removes the ability to nest submenus beyond 5 to avoid scrolling off the screen.
How has this been tested?
Manually tested in desktop.
Screenshots
When choosing a Navigation Link that isn't too nested, the submenu icon appears:
When choosing a Navigation Link that has reached the limit, the icon goes away:
Types of changes
Checklist: