Navigation Block: Increase importance of submenus staying open. #30169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +34 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Tested in TT1 and TT1 blocks: |
priethor
approved these changes
Mar 24, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30113, or at least an aspect discovered in that ticket.
When you create submenus, the submenus should stay visible while you're creating them.
This was not the case after you reached a certain level:
This PR increases the importance of the rules to make that happen:
To explain in a more techinal level, you can see the rules here that are supposed to keep the submenu visible, but being overridden:
The new rules make it so they do not get overridden:
How has this been tested?
Please insert a navigation menu and start empty. Insert a page link, then point it to a page.
Now click the "Add submenu" button in the toolbar, and add a bunch of submenus. While you are creating this monster, observe that the monster stays visible for the whole duration.
Checklist: