Eslint Plugin: Add TypeScript as peer dependency and make it optional #29942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, this is what I see at https://www.npmjs.com/package/typescript
I guess we can't do much about it. |
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
|
Is it possible to create a config which treats *.js and *.ts files separately so we can make TS a peer dependency like eslint? Maybe at least until TS is more common in the project? Basically if a project has no *.ts files don't require TS to be installed. |
sirreal
reviewed
Mar 17, 2021
This is worth exploring, it seems like a straightforward way to address the issue. |
gziolo
changed the title
gziolo
force-pushed
the
fix/missing-ts-dependency
branch
from
4ff7935
to
ae544e9
Compare
|
This is interesting way to declare peer dependencies: "peerDependenciesMeta": {
"typescript": {
"optional": true
}
}, |
gziolo
approved these changes
Mar 18, 2021
|
Based on the comment npm/cli#1247 (comment), I think the This is different for |
Yes, it looks like you are correct and it was implemented as noted it npm/rfcs#221. Detailed documentation is here: |
gziolo
force-pushed
the
fix/missing-ts-dependency
branch
from
bea9962
to
ef5c6ca
Compare
|
|
ocean90
approved these changes
Mar 18, 2021
|
Thank you all for help 🙇🏻 |
gziolo
added a commit
that referenced
this pull request
Mar 19, 2021
…#29942) * Add explicit dependency on TypeScript * Move typescript to a peer dependency * Run TypeScript validation only when it is installed * ESLint Pluging: Add the changelog entry * Clarify the TS integration in the README file * Mark typescript as an optional peer dependency Co-authored-by: Grzegorz Ziolkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an explicit dependency on TypeScript to
eslint-plugin.See #29940 for details.
Fixes #29940
How has this been tested?
npm run buildscriptstofile:../gutenberg/packages/scripts(assuminggutenberglives in the same repository as the test folder for the testpackage.json)For example:
{ "name": "ts", "version": "0.0.0", "description": "", "main": "index.js", "author": "", "license": "private", "devDependencies": { "@wordpress/scripts": "file:../gutenberg/packages/scripts" } }There should be no errors when running
npx wp-scripts lint-js index.jsYou must
npm installin your test directory before runningnpx ...Types of changes
Bug fix
Checklist: