Add padding to link placeholder #29832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
adamziel,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +38 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
draganescu
added
[Feature] Navigation Screen
[Type] Regression
|
cc @jasmussen should that blue hue be like that? It's not a bug as it respects a css var about admin blue, but it looks broken - although I guess that is the message :) for a link with no link. |
|
That does look a bit funky. Here's what it's supposed to look like unselected:
And here's selected:
In the selected case, the background color is set to In this case, the fact that it's blue, suggests that it's inheriting a default blue font color from an ancestor. Which is not the end of the world, and fine to keep intact if it's just from this PR, but in principle it should inherit a dark font color. I'm just about done with my week, but I'm happy to push a tweak next week if it can wait? Otherwise, no blockers for shipping it as just a padding fix. |
talldan
force-pushed
the
add/padding-to-link-placeholder
branch
from
05987a8
to
b3b41b6
Compare
|
Just pushed a small change to make the padding rule the same as for link labels, which should make things more consistent: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a small visual tweak to the link placeholder in the navigation block, when it is used in the navigation editor.
To test:
How has this been tested?
Tested locally
Screenshots
Before
After
Types of changes
Minimal CSS change