Try: Remove important on disabled switcher state. #29552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
CSS Styling
|
Size Change: -3 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Seems like the rule is to ensure the block switch icon is "grayed" out when it's disabled (for normal icons and colored icons like embeds..), if we don't want that anymore, can we just remove the rule? |
|
That shows it like so:
The comment adjacent to it shows this:
So it seems to suggest that it should not be grayed in that state. But I don't have a strong opinion. |
jasmussen
force-pushed
the
try/fix-switcher-icon
branch
from
10d5e13
to
9ede50d
Compare
|
Not sure I understand :P What impact does the rule has no? (after your changes) none? or does it still trigger in some cases? |
|
Sorry, it's definitely a bit fuzzy. This is the full rule in trunk: This PR just removes the !important. With the rule present, !important or not, a locked block, or a block without transformations, looks like this:
With the entire rule removed, it looks like this:
Note the semi transparent block switcher icon. The removal of the !important rule just makes it easier to let the icon colors bleed through. |
|
Ok this makes sense :) Thanks. |
youknowriad
approved these changes
Mar 8, 2021
jasmussen
force-pushed
the
try/fix-switcher-icon
branch
from
9ede50d
to
45f9499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29130 by removing an !important selector.
How has this been tested?
Paste this in your functions.php
Now you have a new CPT, "Podcasts", create a new such and note how the blocks are locked. By being locked, they can't be transformed, meaning the rule to ensure no hover style on the block switcher icon takes effect:
This icon should stay black even when hovering.
Checklist: