Fix Navigation Links when post type is not Page or Post #28892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
force-pushed
the
fix/navigation-posttype-links
branch
from
2e525bc
to
16d5e38
Compare
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
gwwar
force-pushed
the
fix/navigation-posttype-links
branch
from
16d5e38
to
8ac6f25
Compare
gwwar
force-pushed
the
fix/navigation-posttype-links
branch
from
258e1e3
to
e1badf9
Compare
draganescu
reviewed
Feb 12, 2021
| if ( isset( $attributes['id'] ) && is_numeric( $attributes['id'] ) ) { | ||
| if ( | ||
| isset( $attributes['id'] ) && is_numeric( $attributes['id'] ) && | ||
| ( 'post' === $attributes['type'] || 'page' === $attributes['type'] ) |
There was a problem hiding this comment.
I wonder here if we should exclude what get_post does not support (tags, categories) because CPT's (e.g. a book) should also follow this draft logic but we can't add them all to this condition.
There was a problem hiding this comment.
That is a good point @draganescu. Thanks for taking a look! How about we follow up on it in the next PR, since I'm working on #24814 which adds variations for CPTs and taxonomies?
At the moment I'm not sure type is enough to encapsulate what something is. It looks like we're using the post-type and taxonomy slug as a type value, and I'm not sure we enforce uniqueness across the two strings. For example can someone create a poorly named custom taxonomy that collides with a custom post type? I'll need to experiment. We'll also need to respect show_in_nav_menus on both entities.
There was a problem hiding this comment.
As long as this remains on the radar, I am merging this 🚀
draganescu
added
the
[Type] Bug
draganescu
approved these changes
Feb 12, 2021
|
I'm now getting an error on posts with Navigation blocks in them (both in editor and front end): |
|
I noticed that too, fix here - #28999. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check in the navigation link render callback to verify if a link is a post, before checking publish status.
It doesn't look like we have any other examples of this sort of dynamic block test, so I tried to scope the unit as low as possible. Let me know if folks had preferences.
Before
categorypostidoverlap.mp4
After
Manual Testing Instructions
Verify that tests pass:
run
npm run test-unit-phpFixes #28712