Use floating toolbar instead of fixed toolbar in the navigation editor #28769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
talldan
requested review from
adamziel,
draganescu and
kevin940726
as code owners
|
Size Change: -323 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
shaunandrews
deleted the
update/nav-editor-toolbar-from-fixed-to-floating
branch
shaunandrews
pushed a commit
that referenced
this pull request
Feb 5, 2021
talldan
added a commit
that referenced
this pull request
Feb 8, 2021
talldan
added a commit
that referenced
this pull request
Feb 8, 2021
* Just trying a few things out. * Moving things around. * Cleaning up the unnecessary stuff from the editor component. * Move the inspector out of the header and into the main layout. * Moving the inspector to an always visible, fixed sidebar. * Force the Nav block to list items vertically, and add more spacing everything. Also, a nasty hack to fix the block focus outlines. * Removing the styling from the top bar. * Adjusting the space around the link blocks and the appender. * Forcing submenu links to display as normal block elements, indented below their parent link. * Adjusting some spacing, and removing some unused CSS. * Use floating toolbar instead of fixed toolbar in the navigation editor (#28769) * Force navigation screen nav block to vertical variation (#28689) * Moving styles to the right folder, and removing some empty selectors. * Replacing fixed values with variables; Cleaning up spacing; Added border to parents whose children are being edited. * Bringing back submenu arrows and hiding submenus unless the parent link is selected. * Bringing back the removeNavigationBlockEditUnsupportedFeatures, which hides the ability to toggle submenu indicators. * Linting * Update comments * Use SCSS variables * Fix getNavigationPostForMenu test, should expect the menu to be vertical * Update e2e snapshots and skip test for regressed feature Co-authored-by: Daniel Richards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on #28675, and merges into that branch.
With previous designs, the navigation editor had to use a fixed toolbar. With the new design that's not needed. This PR removes all the fixed toolbar code and reverts back to the default floating toolbar.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: