Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Fix buttons faux space-between. #28485

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Try: Fix buttons faux space-between. #28485

merged 2 commits into from
Feb 5, 2021

Conversation

jasmussen
Copy link
Contributor

@jasmussen jasmussen commented Jan 26, 2021

Buttons in the Buttons block appear to be have "space-between" applied, even when they don't:

Screenshot 2021-01-26 at 10 40 34

This is because inside a flex container, if a margin is set to auto, that's the net result.

This PR fixes that. After:

Screenshot 2021-01-26 at 10 40 40

The frontend already worked.

Screenshot 2021-01-26 at 10 40 46

One larger issue is this rule from #21971:

// Extra specificity needed to override default element margins like lists (ul).
.block-editor-block-list__layout .wp-block {
	margin-left: auto;
	margin-right: auto;
}

It's going to continue to cause headaches for flex containers and themes. I wonder if there's a way we can refactor that rule away, without regressing what 21971 meant to fix. CC: @kjellr @scruffian.

Another issue was the use of the _variables.scss stylesheet to store a margin property that was used across the Button and Buttons blocks. It was added in #25999, but no block values should be added there, that stylesheet is purely for UI. And in adding a variable there, it also goes against the componentization / isolation of styles to each block container.

For that reason, I'd very much welcome input on how we can refactor this:

  • The variable, now renamed $blocks-block__margin is used primarily in the Button block stylesheet. This is fine.
  • It's used in the Buttons editor stylesheet only to increase specificity of the rules, due to the "auto" margins mentioned above. This one is hard to fix without refactoring away those auto margins.
  • I'm unsure exactly why it's needed in the Buttons block, it seems like we could let rules here be inherited from the Button block @ntsekouras?

@jasmussen jasmussen self-assigned this Jan 26, 2021
@jasmussen jasmussen added [Block] Buttons Affects the Buttons Block [Type] Code Quality Issues or PRs that relate to code quality labels Jan 26, 2021
@github-actions
Copy link

github-actions bot commented Jan 26, 2021

Size Change: +37 B (0%)

Total Size: 1.37 MB

Filename Size Change
build/block-library/blocks/buttons/editor-rtl.css 233 B +6 B (+3%)
build/block-library/blocks/buttons/editor.css 233 B +6 B (+3%)
build/block-library/blocks/buttons/style-rtl.css 303 B +6 B (+2%)
build/block-library/blocks/buttons/style.css 303 B +6 B (+2%)
build/block-library/editor-rtl.css 9.06 kB +4 B (0%)
build/block-library/editor.css 9.05 kB +4 B (0%)
build/block-library/style-rtl.css 8.62 kB +1 B (0%)
build/block-library/style.css 8.62 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.77 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/index.js 9.08 kB 0 B
build/block-directory/style-rtl.css 1.01 kB 0 B
build/block-directory/style.css 1.01 kB 0 B
build/block-editor/index.js 124 kB 0 B
build/block-editor/style-rtl.css 12 kB 0 B
build/block-editor/style.css 12 kB 0 B
build/block-library/blocks/archives/editor-rtl.css 61 B 0 B
build/block-library/blocks/archives/editor.css 60 B 0 B
build/block-library/blocks/audio/editor-rtl.css 58 B 0 B
build/block-library/blocks/audio/editor.css 58 B 0 B
build/block-library/blocks/audio/style-rtl.css 103 B 0 B
build/block-library/blocks/audio/style.css 103 B 0 B
build/block-library/blocks/block/editor-rtl.css 161 B 0 B
build/block-library/blocks/block/editor.css 161 B 0 B
build/block-library/blocks/button/editor-rtl.css 475 B 0 B
build/block-library/blocks/button/editor.css 474 B 0 B
build/block-library/blocks/button/style-rtl.css 453 B 0 B
build/block-library/blocks/button/style.css 451 B 0 B
build/block-library/blocks/calendar/style-rtl.css 208 B 0 B
build/block-library/blocks/calendar/style.css 208 B 0 B
build/block-library/blocks/categories/editor-rtl.css 84 B 0 B
build/block-library/blocks/categories/editor.css 83 B 0 B
build/block-library/blocks/categories/style-rtl.css 79 B 0 B
build/block-library/blocks/categories/style.css 79 B 0 B
build/block-library/blocks/code/style-rtl.css 90 B 0 B
build/block-library/blocks/code/style.css 90 B 0 B
build/block-library/blocks/columns/editor-rtl.css 190 B 0 B
build/block-library/blocks/columns/editor.css 190 B 0 B
build/block-library/blocks/columns/style-rtl.css 421 B 0 B
build/block-library/blocks/columns/style.css 421 B 0 B
build/block-library/blocks/cover/editor-rtl.css 390 B 0 B
build/block-library/blocks/cover/editor.css 389 B 0 B
build/block-library/blocks/cover/style-rtl.css 1.25 kB 0 B
build/block-library/blocks/cover/style.css 1.25 kB 0 B
build/block-library/blocks/embed/editor-rtl.css 486 B 0 B
build/block-library/blocks/embed/editor.css 486 B 0 B
build/block-library/blocks/embed/style-rtl.css 396 B 0 B
build/block-library/blocks/embed/style.css 395 B 0 B
build/block-library/blocks/file/editor-rtl.css 199 B 0 B
build/block-library/blocks/file/editor.css 198 B 0 B
build/block-library/blocks/file/style-rtl.css 248 B 0 B
build/block-library/blocks/file/style.css 248 B 0 B
build/block-library/blocks/freeform/editor-rtl.css 2.45 kB 0 B
build/block-library/blocks/freeform/editor.css 2.45 kB 0 B
build/block-library/blocks/gallery/editor-rtl.css 679 B 0 B
build/block-library/blocks/gallery/editor.css 679 B 0 B
build/block-library/blocks/gallery/style-rtl.css 1.07 kB 0 B
build/block-library/blocks/gallery/style.css 1.06 kB 0 B
build/block-library/blocks/group/editor-rtl.css 318 B 0 B
build/block-library/blocks/group/editor.css 317 B 0 B
build/block-library/blocks/group/style-rtl.css 57 B 0 B
build/block-library/blocks/group/style.css 57 B 0 B
build/block-library/blocks/heading/editor-rtl.css 129 B 0 B
build/block-library/blocks/heading/editor.css 129 B 0 B
build/block-library/blocks/heading/style-rtl.css 76 B 0 B
build/block-library/blocks/heading/style.css 76 B 0 B
build/block-library/blocks/html/editor-rtl.css 281 B 0 B
build/block-library/blocks/html/editor.css 281 B 0 B
build/block-library/blocks/image/editor-rtl.css 717 B 0 B
build/block-library/blocks/image/editor.css 716 B 0 B
build/block-library/blocks/image/style-rtl.css 477 B 0 B
build/block-library/blocks/image/style.css 478 B 0 B
build/block-library/blocks/latest-comments/editor-rtl.css 159 B 0 B
build/block-library/blocks/latest-comments/editor.css 158 B 0 B
build/block-library/blocks/latest-comments/style-rtl.css 269 B 0 B
build/block-library/blocks/latest-comments/style.css 269 B 0 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B 0 B
build/block-library/blocks/latest-posts/editor.css 137 B 0 B
build/block-library/blocks/latest-posts/style-rtl.css 523 B 0 B
build/block-library/blocks/latest-posts/style.css 522 B 0 B
build/block-library/blocks/list/editor-rtl.css 65 B 0 B
build/block-library/blocks/list/editor.css 65 B 0 B
build/block-library/blocks/list/style-rtl.css 63 B 0 B
build/block-library/blocks/list/style.css 63 B 0 B
build/block-library/blocks/media-text/editor-rtl.css 191 B 0 B
build/block-library/blocks/media-text/editor.css 191 B 0 B
build/block-library/blocks/media-text/style-rtl.css 535 B 0 B
build/block-library/blocks/media-text/style.css 532 B 0 B
build/block-library/blocks/more/editor-rtl.css 434 B 0 B
build/block-library/blocks/more/editor.css 434 B 0 B
build/block-library/blocks/navigation-link/editor-rtl.css 392 B 0 B
build/block-library/blocks/navigation-link/editor.css 394 B 0 B
build/block-library/blocks/navigation-link/style-rtl.css 704 B 0 B
build/block-library/blocks/navigation-link/style.css 702 B 0 B
build/block-library/blocks/navigation/editor-rtl.css 1.38 kB 0 B
build/block-library/blocks/navigation/editor.css 1.37 kB 0 B
build/block-library/blocks/navigation/style-rtl.css 174 B 0 B
build/block-library/blocks/navigation/style.css 174 B 0 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B 0 B
build/block-library/blocks/nextpage/editor.css 395 B 0 B
build/block-library/blocks/paragraph/editor-rtl.css 109 B 0 B
build/block-library/blocks/paragraph/editor.css 109 B 0 B
build/block-library/blocks/paragraph/style-rtl.css 273 B 0 B
build/block-library/blocks/paragraph/style.css 273 B 0 B
build/block-library/blocks/post-author/editor-rtl.css 209 B 0 B
build/block-library/blocks/post-author/editor.css 209 B 0 B
build/block-library/blocks/post-author/style-rtl.css 183 B 0 B
build/block-library/blocks/post-author/style.css 184 B 0 B
build/block-library/blocks/post-comments-form/style-rtl.css 249 B 0 B
build/block-library/blocks/post-comments-form/style.css 249 B 0 B
build/block-library/blocks/post-content/editor-rtl.css 139 B 0 B
build/block-library/blocks/post-content/editor.css 139 B 0 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B 0 B
build/block-library/blocks/post-excerpt/editor.css 73 B 0 B
build/block-library/blocks/post-featured-image/editor-rtl.css 338 B 0 B
build/block-library/blocks/post-featured-image/editor.css 338 B 0 B
build/block-library/blocks/post-featured-image/style-rtl.css 100 B 0 B
build/block-library/blocks/post-featured-image/style.css 100 B 0 B
build/block-library/blocks/preformatted/style-rtl.css 63 B 0 B
build/block-library/blocks/preformatted/style.css 63 B 0 B
build/block-library/blocks/pullquote/editor-rtl.css 183 B 0 B
build/block-library/blocks/pullquote/editor.css 183 B 0 B
build/block-library/blocks/pullquote/style-rtl.css 316 B 0 B
build/block-library/blocks/pullquote/style.css 316 B 0 B
build/block-library/blocks/query-loop/editor-rtl.css 90 B 0 B
build/block-library/blocks/query-loop/editor.css 89 B 0 B
build/block-library/blocks/query-loop/style-rtl.css 315 B 0 B
build/block-library/blocks/query-loop/style.css 317 B 0 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B 0 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B 0 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B 0 B
build/block-library/blocks/query-pagination/editor.css 262 B 0 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B 0 B
build/block-library/blocks/query-pagination/style.css 168 B 0 B
build/block-library/blocks/query/editor-rtl.css 159 B 0 B
build/block-library/blocks/query/editor.css 160 B 0 B
build/block-library/blocks/quote/editor-rtl.css 61 B 0 B
build/block-library/blocks/quote/editor.css 61 B 0 B
build/block-library/blocks/quote/style-rtl.css 169 B 0 B
build/block-library/blocks/quote/style.css 169 B 0 B
build/block-library/blocks/rss/editor-rtl.css 201 B 0 B
build/block-library/blocks/rss/editor.css 202 B 0 B
build/block-library/blocks/rss/style-rtl.css 290 B 0 B
build/block-library/blocks/rss/style.css 290 B 0 B
build/block-library/blocks/search/editor-rtl.css 165 B 0 B
build/block-library/blocks/search/editor.css 165 B 0 B
build/block-library/blocks/search/style-rtl.css 342 B 0 B
build/block-library/blocks/search/style.css 344 B 0 B
build/block-library/blocks/separator/editor-rtl.css 99 B 0 B
build/block-library/blocks/separator/editor.css 99 B 0 B
build/block-library/blocks/separator/style-rtl.css 236 B 0 B
build/block-library/blocks/separator/style.css 236 B 0 B
build/block-library/blocks/shortcode/editor-rtl.css 504 B 0 B
build/block-library/blocks/shortcode/editor.css 504 B 0 B
build/block-library/blocks/site-logo/editor-rtl.css 201 B 0 B
build/block-library/blocks/site-logo/editor.css 201 B 0 B
build/block-library/blocks/site-logo/style-rtl.css 117 B 0 B
build/block-library/blocks/site-logo/style.css 117 B 0 B
build/block-library/blocks/social-link/editor-rtl.css 164 B 0 B
build/block-library/blocks/social-link/editor.css 165 B 0 B
build/block-library/blocks/social-links/editor-rtl.css 711 B 0 B
build/block-library/blocks/social-links/editor.css 712 B 0 B
build/block-library/blocks/social-links/style-rtl.css 1.37 kB 0 B
build/block-library/blocks/social-links/style.css 1.37 kB 0 B
build/block-library/blocks/spacer/editor-rtl.css 302 B 0 B
build/block-library/blocks/spacer/editor.css 302 B 0 B
build/block-library/blocks/spacer/style-rtl.css 48 B 0 B
build/block-library/blocks/spacer/style.css 48 B 0 B
build/block-library/blocks/subhead/editor-rtl.css 99 B 0 B
build/block-library/blocks/subhead/editor.css 99 B 0 B
build/block-library/blocks/subhead/style-rtl.css 80 B 0 B
build/block-library/blocks/subhead/style.css 80 B 0 B
build/block-library/blocks/table/editor-rtl.css 489 B 0 B
build/block-library/blocks/table/editor.css 489 B 0 B
build/block-library/blocks/table/style-rtl.css 386 B 0 B
build/block-library/blocks/table/style.css 386 B 0 B
build/block-library/blocks/tag-cloud/editor-rtl.css 118 B 0 B
build/block-library/blocks/tag-cloud/editor.css 118 B 0 B
build/block-library/blocks/tag-cloud/style-rtl.css 94 B 0 B
build/block-library/blocks/tag-cloud/style.css 94 B 0 B
build/block-library/blocks/template-part/editor-rtl.css 680 B 0 B
build/block-library/blocks/template-part/editor.css 679 B 0 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B 0 B
build/block-library/blocks/text-columns/editor.css 95 B 0 B
build/block-library/blocks/text-columns/style-rtl.css 166 B 0 B
build/block-library/blocks/text-columns/style.css 166 B 0 B
build/block-library/blocks/verse/editor-rtl.css 62 B 0 B
build/block-library/blocks/verse/editor.css 62 B 0 B
build/block-library/blocks/verse/style-rtl.css 87 B 0 B
build/block-library/blocks/verse/style.css 87 B 0 B
build/block-library/blocks/video/editor-rtl.css 504 B 0 B
build/block-library/blocks/video/editor.css 503 B 0 B
build/block-library/blocks/video/style-rtl.css 193 B 0 B
build/block-library/blocks/video/style.css 193 B 0 B
build/block-library/common-rtl.css 1.01 kB 0 B
build/block-library/common.css 1.01 kB 0 B
build/block-library/index.js 144 kB 0 B
build/block-library/theme-rtl.css 748 B 0 B
build/block-library/theme.css 748 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/blocks/index.js 48.3 kB 0 B
build/components/index.js 279 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 11.2 kB 0 B
build/core-data/index.js 16.8 kB 0 B
build/data-controls/index.js 827 B 0 B
build/data/index.js 8.86 kB 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 570 B 0 B
build/dom/index.js 4.93 kB 0 B
build/edit-navigation/index.js 11.2 kB 0 B
build/edit-navigation/style-rtl.css 1.01 kB 0 B
build/edit-navigation/style.css 1.01 kB 0 B
build/edit-post/index.js 307 kB 0 B
build/edit-post/style-rtl.css 6.79 kB 0 B
build/edit-post/style.css 6.78 kB 0 B
build/edit-site/index.js 24.2 kB 0 B
build/edit-site/style-rtl.css 4.04 kB 0 B
build/edit-site/style.css 4.04 kB 0 B
build/edit-widgets/index.js 20.1 kB 0 B
build/edit-widgets/style-rtl.css 3.2 kB 0 B
build/edit-widgets/style.css 3.2 kB 0 B
build/editor/editor-styles-rtl.css 543 B 0 B
build/editor/editor-styles.css 545 B 0 B
build/editor/index.js 41.9 kB 0 B
build/editor/style-rtl.css 3.89 kB 0 B
build/editor/style.css 3.89 kB 0 B
build/element/index.js 4.61 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.77 kB 0 B
build/format-library/style-rtl.css 637 B 0 B
build/format-library/style.css 639 B 0 B
build/hooks/index.js 2.28 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.74 kB 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/keyboard-shortcuts/index.js 2.54 kB 0 B
build/keycodes/index.js 1.93 kB 0 B
build/list-reusable-blocks/index.js 3.15 kB 0 B
build/list-reusable-blocks/style-rtl.css 629 B 0 B
build/list-reusable-blocks/style.css 628 B 0 B
build/media-utils/index.js 5.35 kB 0 B
build/notices/index.js 1.85 kB 0 B
build/nux/index.js 3.41 kB 0 B
build/nux/style-rtl.css 731 B 0 B
build/nux/style.css 727 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.42 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/reusable-blocks/index.js 2.92 kB 0 B
build/rich-text/index.js 13.4 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 3.01 kB 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@aristath aristath self-requested a review January 28, 2021 08:33
@jasmussen jasmussen requested a review from a team January 28, 2021 08:40
@youknowriad youknowriad added Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Type] Bug An existing feature does not function as intended and removed [Type] Code Quality Issues or PRs that relate to code quality labels Jan 28, 2021
@scruffian
Copy link
Contributor

I can't replicate this in master.

@jasmussen
Copy link
Contributor Author

I can't replicate this in master.

Sorry, I should've clarified in the instructions. It depends a little on the theme. Some people style those Button blocks, and inadvertently fix this, others do less. I think if a theme doesn't style those buttons, it's more likely to happen.

You can try TT1 Blocks, I can reproduce it there. Theoretically you could also reproduce it by toggling off editor styles:

Screenshot 2021-01-28 at 12 38 08

@scruffian
Copy link
Contributor

This looks good in the editor but not so good in TT1 Blocks on the frontend:
Screenshot 2021-01-28 at 11 44 08

@scruffian
Copy link
Contributor

It's going to continue to cause headaches for flex containers and themes. I wonder if there's a way we can refactor that rule away, without regressing what 21971 meant to fix. CC: @kjellr @scruffian.

To me this seems to be a function of the way we deal wide/full alignments. We try to keep the site content 100% wide so that we can implement wide and full alignments, but this causes other issues. IMO we should just constrain the site to whatever the content width is and then let blocks break out of it when they are wide/full width...

@jasmussen
Copy link
Contributor Author

Thank you for reviewing and chiming in, I appreciate that a lot.

IMO we should just constrain the site to whatever the content width is and then let blocks break out of it when they are wide/full width...

So negative margins or something like that? This is tricky to accomplish in the editor without the iframe, because vw units don't work. It's also a little bit less flexible with regards to various layouts you might want to use. Technically a theme could do this already now in the editor style (aside from the vw unit).

Perhaps the real solution is the refactor of wide and fullwide to be more of a prop on the container than a default for post content, which Riad has been talking about for a while.

Looking at that frontend issue now, thank you, good catch!

@scruffian
Copy link
Contributor

Bring on the iframe!

@jasmussen
Copy link
Contributor Author

Thanks for testing, everyone. It appears there's an issue with TT1 Blocks on the frontend, and I will look at what that is as soon as I can. I'm currently having some trouble getting TT1 Blocks to work with the plugin, and I believe things will work once WordPress/theme-experiments#182 lands. When that happens, I'll test again, and revisit!

@jasmussen
Copy link
Contributor Author

I managed to push a fix for TT1 blocks frontend. Before:

Screenshot 2021-02-05 at 08 57 45

After:

Screenshot 2021-02-05 at 09 05 30

It's this TT1 blocks CSS that does it:

Screenshot 2021-02-05 at 08 58 01

Blanket targetting like that is arguably not best practice, but nevertheless it's fair enough to do, so I felt it okay to push a fix here.

Pleas test this one again, and test:

  • No justification
  • Left, center, right justifications.

@aristath
Copy link
Member

aristath commented Feb 5, 2021

Should this fix be in Gutenberg, or in TT1-blocks? 🤔

@ntsekouras
Copy link
Contributor

Thanks for working on this Joen!

Should this fix be in Gutenberg, or in TT1-blocks? 🤔

I also feel like this should be in TT1-blocks, since everything works well when testing with Twenty Twenty-One.

Also in this PR the buttons don't work well with vertical orientation.

@jasmussen
Copy link
Contributor Author

That was my question to myself as well. However two reasons made me choose to include the fix here:

  1. Because Buttons is a flex container with justification controls, the margin properties are intrinsic to the alignment.
  2. Many more themes than just TT1 blocks blanket target blocks like this. It's not good practice, but I believe it's best to account for it, at least a little bit.

@jasmussen
Copy link
Contributor Author

Thank you Nik, I'll take a look at the vertical orientation.

@jasmussen
Copy link
Contributor Author

@ntsekouras what issues are you seeing with the vertical orientation? It seems to be working for me:

Screenshot 2021-02-05 at 09 45 11

@ntsekouras
Copy link
Contributor

@ntsekouras what issues are you seeing with the vertical orientation? It seems to be working for me:

Sorry I didn't clarify. It doesn't seem to work on the front-end. Buttons seem to always be right.

@jasmussen
Copy link
Contributor Author

I'm not seeing that in TT1 blocks, or my own theme, in this branch:

buttons

Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great! Thanks Joen!

My comments about vertical were due to some development env problem of mine 😄

@jasmussen
Copy link
Contributor Author

Let's land this as it improves the flex situation of the Buttons block a great deal, and I'm happy to follow up on any issues. Thanks all.

@jasmussen jasmussen merged commit b634e7b into master Feb 5, 2021
@jasmussen jasmussen deleted the try/buttons-flex-fix branch February 5, 2021 09:40
@github-actions github-actions bot added this to the Gutenberg 10.0 milestone Feb 5, 2021
noisysocks pushed a commit that referenced this pull request Feb 7, 2021
* Try: Fix buttons faux space-between.

* TT1 fix.
noisysocks pushed a commit that referenced this pull request Feb 8, 2021
* Try: Fix buttons faux space-between.

* TT1 fix.
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants