Testing: Add CI workflow covering Node.js 12 #28139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
the
[Type] Automated Testing
|
Size Change: +2.36 kB (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
gziolo
added
[Type] Build Tooling
gziolo
force-pushed
the
add/node-12-workflow
branch
from
b917976
to
6a16fa1
Compare
gziolo
force-pushed
the
add/node-12-workflow
branch
from
6a16fa1
to
567f569
Compare
|
Should we use a matrix for the "static tests" job instead of adding a dedicated job? |
That's an interesting idea I should consider in the first place. You need to run |
|
Now, I see that we discussed that it should run only when merging with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment Gutenberg runs all checks with the active LTS version of Node.js that is 14.x. However, we declare support for Node.js 12.x in packages we distribute on npm. This is an effort to catch any regressions that might happen moving forward.
It was triggered by #27934 where the minimum version of Node.js was set to Node 12.x for several packages. It was also discussed during the weekly WordPress Core JS chat:
https://wordpress.slack.com/archives/C5UNMSU4R/p1609860339178800
(link requires to log in at https://make.wordpress.org/chat/)
This PR enables checks using Node.js 12 for:
It also enables those check on
wp/trunkbranch that is used for npm publishing.How has this been tested?
See GitHub actions below 😄
All of them should still pass including those that run with Node 12.
With the current setup Create Block workflow doesn't trigger when there are no changes in the
packagesfolder.