Remove CSS Custom Property in code block #27672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Block] Code
This was referenced Dec 11, 2020
|
Size Change: -119 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
I thought some sizes are part of Global Styles and not theme dependent - for example The advantage I see with using a variable is that the font sizes will be the same in every context and will be more transparent to the user. With this change the font size will be smaller but the user won't be able to explicitly see why. |
|
Those variables are not present unless a particular theme declares them via theme.json, so we can't use them. This change won't affect anything because when the variable is not present the default value is taken. If a theme wants to set that particular value for font-size it should use the theme.json and the user will see it. |
|
Even for the default font sizes declared via the core theme.json we don't do it that way ― these variables won't be present if the theme declares different ones. For context, we explored the alternative introduced in the code block (use CSS Custom Property directly into the block's CSS). See "style hooks" for blocks in #22296 |
scruffian
pushed a commit
that referenced
this pull request
Dec 15, 2020
* Add preformatted block styles and font settings. * Add font size fallback. * Remove unnecessary overflow property and use `pre-wrap` instead. This is a more elegant solution compared to the previous one, which relied on overflow. * Remove editor.scss * Remove CSS custom property. This is the theme's job. For more information, see #27672 * Add stylesheet to `block.json` file This is added due to new requirement implemented in #25220 Co-authored-by: Ari Stathopoulos <[email protected]> * Add preformatted block to theme-json.md specs. * Fix preformatted block support information on theme-json.md specs. Co-authored-by: Ari Stathopoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27294 introduced the use of a CSS Custom Property to set the font size of the code block.
However, the property
--wp--preset--font-size--extra-smallis theme dependant, it doesn't exist unless a particular theme adds it. The mechanism for a theme to set the value of the font-size of a block is via theme.json:This PR reverts that change.