-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gutenberg_is_fse_theme function. #27021
Conversation
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. Though I do imagine folks like @youknowriad might know more about why we used STYLESHEETPATH
in the first place
See the full discussion #26500 (comment) where @vindl proposed the current approach:
|
bb6c77e
to
e984d7e
Compare
It was the only relevant piece from |
Description
Im hoping to use
get_stylesheet_directory()
here instead ofSTYLESHEETPATH
. Using STYLESHEETPATH can be problematic on multisite installs which would like to determine if a site is FSE eligible from an external management interface. This can be problematic if 'STYLESHEETPATH' is read and referenced before it is redefined to be accurate in the more complex system context.How has this been tested?
Screenshots
Types of changes
Checklist: