Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package lock file #26439

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Update package lock file #26439

merged 1 commit into from
Oct 26, 2020

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Oct 26, 2020

Description

Static analysis is failing in master at the moment due to a change in the package lock file.

This seems to happen from time to time, previously #25489

@talldan
Copy link
Contributor Author

talldan commented Oct 26, 2020

There are some typescript failures at the moment:

  npm ERR! prepareGitDep > bob build
  npm ERR! prepareGitDep 
  npm ERR! prepareGitDep ℹ Building target commonjs
  npm ERR! prepareGitDep ℹ Cleaning up previous build at lib/commonjs
  npm ERR! prepareGitDep ℹ Compiling 9 files in src with babel
  npm ERR! prepareGitDep ✓ Wrote files to lib/commonjs
  npm ERR! prepareGitDep ℹ Building target module
  npm ERR! prepareGitDep ℹ Cleaning up previous build at lib/module
  npm ERR! prepareGitDep ℹ Compiling 9 files in src with babel
  npm ERR! prepareGitDep ✓ Wrote files to lib/module
  npm ERR! prepareGitDep ℹ Building target typescript
  npm ERR! prepareGitDep ℹ Cleaning up previous build at lib/typescript
  npm ERR! prepareGitDep ℹ Generating type definitions with tsc
  npm ERR! prepareGitDep src/native-stack/navigators/createNativeStackNavigator.tsx:32:5 - error TS2314: Generic type 'StackNavigationState' requires 1 type argument(s).
  npm ERR! prepareGitDep 
  npm ERR! prepareGitDep 32     StackNavigationState,

Judging by the naming this is related to the mobile part of the codebase?

It's something that was happening prior to this PR (see https://github.com/WordPress/gutenberg/runs/1306742896), so I'll merge this regardless, as it solves the failing Static Analysis test.

@talldan talldan added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Oct 26, 2020
@talldan talldan merged commit 60c5bb6 into master Oct 26, 2020
@talldan talldan deleted the fix/package-lock-change branch October 26, 2020 04:38
@github-actions github-actions bot added this to the Gutenberg 9.3 milestone Oct 26, 2020
@talldan talldan mentioned this pull request Oct 26, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant