-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sticky support in Query block #26279
Conversation
Size Change: +189 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
As described over here there are three options:
(Locally tested.) The sticky option itself is a boolean – but using the option at all is another option, therefore we have 3 options and it’s definetely needed. If one wants to show “only sticky posts” in one Query Block, you need the option to exclude sticky posts in another Query Block to prevent duplicates. |
Hey @mariohamann - thanks for pointing this out! I pushed changes to handle all cases. |
@scruffian The naming was my proposal, but I hadn't the label in mind when thinking about it (only thought about the options). In fact, you are absolutely right. What do you think about the following proposals to make it shorter and – in my opinion – more clear?
OR
|
I like both. I'd put |
@ntsekouras 👍🏻 Thanks for relabeling once more! |
b62573d
to
34f5966
Compare
96d2107
to
f58ed4d
Compare
f58ed4d
to
84e3886
Compare
Description
Part of: #24934
This PR adds
sticky
support in theQuery
block. There are three options:Reference: https://developer.wordpress.org/rest-api/reference/posts/#arguments
Another not related thing this PR changes, is some whitespaces differences that occurred during the regeneration of fixtures. The regeneration tool uses
spaces
and there were some handwritten withtabs
.Checklist: