Serializer: Capture and recover from save errors #2618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2267
This pull request seeks to appropriately recover from unhandled errors occurring during a block's
save
implementation. Not only does this help prevent a BSOD (blank screen of death), it also preserves the original content of the block in which the error had occurred (same treatment as in an invalid block).Implementation notes:
The majority of changes are regenerated fixtures, because we now always assign
originalContent
into the parsed block object, not just when the post is invalid, since we fall back on this content if an error occurs during the save step.Testing instructions:
You'll need to manually add the Mr. Crashy block registration prior to editor initialization. I recommend at the bottom of
editor/index.js
: