Add template lock attribute to column and group #26128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ajitbohra,
nerrad,
ntwb,
Soean and
talldan
as code owners
|
Size Change: +38 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/templateLock-attribute-to-columns-and-group
branch
from
53f51a0
to
0abfa0c
Compare
mcsf
reviewed
Oct 16, 2020
Co-authored-by: Miguel Fonseca <[email protected]>
jorgefilipecosta
force-pushed
the
add/templateLock-attribute-to-columns-and-group
branch
from
78d6b90
to
c1d343d
Compare
|
Hi @mcsf, your feedback was applied. |
mcsf
approved these changes
Oct 16, 2020
Co-authored-by: Miguel Fonseca <[email protected]>
jorgefilipecosta
force-pushed
the
add/templateLock-attribute-to-columns-and-group
branch
from
c1d343d
to
120abca
Compare
jorgefilipecosta
deleted the
add/templateLock-attribute-to-columns-and-group
branch
Comment on lines
+15
to
+16
| "templateLock": { | ||
| "type": "string" |
There was a problem hiding this comment.
Shouldn't this be a boolean?
There was a problem hiding this comment.
Hi @ZebulanStanphill, the template lock attribute can contain values like "all", and "insert" which are strings.
6 tasks
Closed
6 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a templateLock attribute to columns and group. When this attribute is set the locking of the blocks is set to the attribute value instead of relying on the inherited value.
This allows the locking of these blocks to be controlled by templates, patterns, etc.
supersedes: #25869
How has this been tested?
I verified now locking is not inherited by using sample cpt templates, and sample blocks with inner block templates.
I verified I could control the locking of the group block by using the templateLock attribute.
By pasting the following code on the code editor I verified that the first group block is not locked, while the second group block is locked.
I verified I could control the locking of a column by pasting the following code on the code editor I verified column 1 is locked while the second column is not.