Mark a block to signal its creation from a block variation #26105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Block Variations
|
Size Change: +237 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
I can second that. In #26025 (comment) I described, that I miss the title of the variation in inspector controls. Therefore, the final blocks needs to know which variation it is based on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has the goal to mark a Block with an attribute, that indicates the block variation that was created from. This is a prototype for now to discuss the approach taken.
This is a step forward to properly implementing block 'transformations' (actually block updates) from a block to one of its block variations. For example 'transform' a
Navigation (vertical)block to `Navigation (horizontal).Related issues:
#25231
#20584
This will be also useful to provide better information in the UI, in places like the
toolbarand theinspector controls(icon, title, description etc..).This will have no backwards compatibility problems as the previously created blocks from variations, will have the same behaviour. You can test that newly created blocks (ex
Navigation (..)) change theblock switchericon and theblock cardin inspector controls show the proper information.If current approach seems viable, there are more things to be added here like:
core/blocksthat use theplaceholder patternlikeColumnsetcrawtransformations ofembedblock when aurlis pastedetc..
Types of changes
Checklist: