Block API: light block edit/save symmetry #25644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
ajlende,
mkaz,
Soean,
talldan and
youknowriad
as code owners
ellatrix
added
the
[Feature] Block API
This was referenced Sep 25, 2020
|
Size Change: +190 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Sep 25, 2020
ellatrix
force-pushed
the
try/block-api-symmetry
branch
from
58d34c6
to
568d0be
Compare
ellatrix
force-pushed
the
try/block-api-symmetry
branch
from
568d0be
to
3f6715a
Compare
youknowriad
reviewed
Sep 25, 2020
| @@ -2,13 +2,14 @@ | |||
| * WordPress dependencies | |||
| */ | |||
| import { RichText } from '@wordpress/block-editor'; | |||
| import { getBlockProps } from '@wordpress/blocks'; | |||
There was a problem hiding this comment.
I actually wonder about the best place to export this, maybe useBlockProps.save()?
There was a problem hiding this comment.
That's possible too. I don't mind either way. I'll update it :)
There was a problem hiding this comment.
This looks much nicer actually! :)
There was a problem hiding this comment.
I'm not sure how I feel about exposing it through useBlockProps.save(). It feels a little weird to me, but I also don't outright dislike it. I'm okay with it either way. I suppose one benefit is that it more closely ties it to useBlockProps.
There was a problem hiding this comment.
The reasoning for proposing this is that later we might have useInnerBlocks.save() , useRichText.save()
There was a problem hiding this comment.
Yes, I like this pattern. Good idea!
ZebulanStanphill
added
the
[Type] New API
|
I like this personally, i'd like more opinions here @mcsf @mtias @jorgefilipecosta |
ellatrix
force-pushed
the
try/block-api-symmetry
branch
from
b32086b
to
84aeb9e
Compare
youknowriad
reviewed
Sep 25, 2020
packages/block-editor/src/components/block-list/block-wrapper.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Sep 25, 2020
packages/block-editor/src/components/block-list/block-wrapper.js
Outdated
Show resolved
Hide resolved
ellatrix
force-pushed
the
try/block-api-symmetry
branch
from
100e873
to
062d519
Compare
youknowriad
approved these changes
Sep 25, 2020
|
I'll let it sit over the weekend. Would be nice to ship early Monday so we can stabilise it for the release. |
|
Nice work here. There are some aspects that I like:
What I don't like as much:
All in all, I lean more towards yes than no, but it feels a little like a step in the dark. |
It doesn't really matter, you can do both. You can also pass the props to
Similarly, |
Nothing would break, since this API is opt-in. |
|
Let's do it. :) |
6 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the earlier attempt #20721.
Things have changed now with the replacement of the block component by a hook in #23034.
This must be done before stabilising the new (light) block API, because we're using the supports flag to adjust serialisation.
It creates a bit of consistency in the API, the only difference being that for
editit's a hook adding behaviours and forsaveit's a simple functionuseBlockProps.saveto insert (filtered) attributes on the block wrapper.How has this been tested?
Screenshots
Types of changes
Checklist: