You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes and regression introduced by this PR where some props were missing in the RichText component for the Buttons block causing it impossible to type any text in it.
How has this been tested?
Open the app with metro running
Add a Buttons block
Expect to be able to type in texts inside the buttons
Screenshots
Before
After
Types of changes
Bug fix
Checklist:
My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR.
Thanks for the fix, @geriux! It's working well, although I noticed a difference between Gutenberg on the the current App Store 15.7 version and this.
On WPiOS 15.7, when you add two Buttons, one after the other — the first button which loses focus shows a placeholder of "Add text..." when the second button is added. On this branch I don't see the placeholder. Do you think this could be related to the same breakage?
Thanks for the fix, @geriux! It's working well, although I noticed a difference between Gutenberg on the the current App Store 15.7 version and this.
On WPiOS 15.7, when you add two Buttons, one after the other — the first button which loses focus shows a placeholder of "Add text..." when the second button is added. On this branch I don't see the placeholder. Do you think this could be related to the same breakage?
Nice catch @guarani! I've missed some props 😅 I've just updated the PR. Thanks!
Thanks @geriux! Tested on iOS and it's working great.
Thanks for testing! Unfortunately with the latest changes it breaks the web editor, looks like passing the id prop breaks it. @lukewalczak Since you worked on the Buttons block, do you have any idea why this could be happening?
Some time ago I had a similar issue, where style prop has to be destructured separately. I was testing it in multiple different ways, comparing them by reference and at the end values and objects were always the same. Unfortunately, I have no clue what is wrong :(
Mobile App - i.e. Android or iOSNative mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)[Type] BugAn existing feature does not function as intended
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geriux
added
the
Mobile App - i.e. Android or iOS
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2665Fixes #25623
Description
This PR fixes and regression introduced by this PR where some props were missing in the
RichTextcomponent for theButtonsblock causing it impossible to type any text in it.How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: