Block API: deprecate experimental Block.* component #25515
Conversation
ellatrix
requested review from
ajitbohra,
mkaz,
Soean,
talldan and
youknowriad
as code owners
ellatrix
added
the
[Feature] Block API
|
Size Change: -1 B Total Size: 1.17 MB
ℹ️ View Unchanged
|
|
The test failures (or at least one of them) are legitimate. I tried going through the steps of "Navigating the block hierarchy › should navigate using the block hierarchy dropdown menu" manually, and when I tried to perform the "tab twice" action on line 69, the inserter closed. No clue what's causing that issue yet, but I'm pretty sure it's not related to the tweak in |
|
@ZebulanStanphill Yes, it's a strange issue... it seems related to inner blocks and perhaps unnecessary re-renders. |
|
|
ellatrix
changed the title
ellatrix
changed the title
| hasInnerBlocks={ innerBlocks.length > 0 } | ||
| /> | ||
| </TagName> | ||
| <Content |
There was a problem hiding this comment.
Maybe it's just me but I don't see what these two components bring aside indirection.
There was a problem hiding this comment.
The problem is that you cannot use useBlockWrapperProps without having an element that set a ref that you can add event listeners to.
There was a problem hiding this comment.
I guess it's the "return null" that causes the issue.
There was a problem hiding this comment.
Right. If you have multiple paths that are all creating a block, it would be fine to "share" the hook. Not sure if in this care we can just return a placeholder block or something. A block not returning anything is strange. There's a block, but you can't see it?
There was a problem hiding this comment.
yes, it's probably some hidden bug somewhere there but can be handled separately tbh.
There was a problem hiding this comment.
@youknowriad I reverted the previous change and now it will always render a block. If the post ID is not resolved it will output "Loading..." Not sure if that's the best, but we can change the loading thing later on if needed. Imo we should always render a block even when it's still loading.
There was a problem hiding this comment.
You're right, good fix, thanks for the update.
There was a problem hiding this comment.
Ugh, some tests are failing now. :)
ellatrix
force-pushed
the
try/deprecate-block-component
branch
2 times, most recently
from
c4dcbc6
to
ff0b08f
Compare
ellatrix
force-pushed
the
try/deprecate-block-component
branch
from
98e18a2
to
6ee2199
Compare
|
Changes to
cc @ellatrix |
Description
With the newly introduced
useBlockWrapperPropsin #23034, the experimentalBlock.*component can be deprecated. Since plugins are likely to use this component (even though it's experimental), we should not remove it for at least a few releases.How has this been tested?
Screenshots
Types of changes
Checklist: