Navigation component: Add color to menu and group title #25507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more specific so it won't be overriden by other CSS
david-szabo97
added
the
[Feature] Navigation Component
david-szabo97
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
8 tasks
|
Size Change: -1 B Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
@david-szabo97 I'd suggest adding these colors to the original PR #25506 instead, and close this. At first I was about to ask you to replace the hex codes with the G2 color, but then I realized we already use that same hex color (and others) elsewhere in the Nav styles. Eventually we'll need to discuss, revamp, and polish the menu colors, so imho this change is not essential, even more so as #25506 is currently an exploration. 🙂 |
vindl
reviewed
Sep 21, 2020
|
@Copons Eventually we will need to add a color to these elements. Since they aren't a simple div or span which is usually unstyled. I'm fine with adding this little change in the exploration PR, but I'd rather have it merged to make sure we don't forget about it. I'm sure the color will change in the future when the design is finalized, but it's easier to find and replace than figure out why it isn't working as expected. |
vindl
approved these changes
Sep 21, 2020
Copons
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
colorproperty toMenuTitleUiandGroupTitleUito make them more specific.See #25506
Types of changes
Bug Fix
Checklist: