Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Supports: Ensure consistent output in different PHP versions #25240

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Block Supports: Ensure consistent output in different PHP versions #25240

merged 3 commits into from
Sep 11, 2020

Commits on Sep 11, 2020

  1. Get DOM root and extract substring contents 

    In some versions of PHP (< 7.3) the `DOMDocument::saveHtml( $node )`
method would format HTML introducing whitespace that could result in
different rendered results in the browser.

Avoid using the `DOMDocument::saveHtml( $node )` to ensure consistent
behavior with supported PHP versions.

Mentioned here:
#25028 (comment)
    @sirreal
    sirreal committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    3ce013f View commit details
    Browse the repository at this point in the history

  2. Drop mb_ versions

    @sirreal
    sirreal committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    20646ab View commit details
    Browse the repository at this point in the history

  3. Trim result

    @sirreal
    sirreal committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    d104c75 View commit details
    Browse the repository at this point in the history