-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Comments Counts: Add style attributes #24167
Conversation
Size Change: +147 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and works well for me. All concerns are regarding designs that will need to be addressed in the future.
Initially this was a span
on the front end, I don't know if this made sense or not. Since we are adding feature parity in comparison with the paragraph block, we probably do want it as a block element. It seems a bit empty as a block element, but perhaps in future iterations we can add a customizable text that can be added before or after the number, so someone could customize the block more like:
This many comments: 0
or
This post has 0 comments!
😆
Yeah, having a custom label (maybe even with a custom |
Description
Update the Post Comments Counts block:
div
instead of aspan
.Note: the block simply outputs the number of comments, without labels.
How has this been tested?
Tested in Post, Page, and Site Editor, on Chrome 83 on macOS 10.15.5.
Tested on posts and pages, with comments allowed and otherwise.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: